mirror of
https://github.com/MarijnDoeve/TijdVoorDeTest.git
synced 2026-07-11 12:28:23 +02:00
Marijn
2fd15ba8fa
* test: expand coverage, dedupe data-driven tests, extract shared WebTestCase base - Add #[CoversClass] to Base64Test and FilenameSanitizerTest - Merge near-duplicate test methods into #[DataProvider] cases across ResetPasswordControllerTest, SettingsControllerTest, ClaimSeasonCommandTest, FilenameSanitizerTest, Base64Test, and SeasonRepositoryTest - Add integration tests for previously untested controllers: public QuizController (quiz-taking flow), LoginController, RegistrationController, EliminationController, and PrepareEliminationController - Add unit tests for Elimination and BankQuestion entity logic - Extract shared WebTestCase setup/helpers (client, entityManager, login, entity lookups, CSRF token scraping) into AbstractControllerWebTestCase, removing duplicated boilerplate from all 14 WebTestCase files * test: address PR review feedback - Scope AbstractControllerWebTestCase::getCandidate/getQuizByName by season code (both Candidate and Quiz are only unique per season, not system-wide) and add a CandidateRepository regression test guarding against same-named candidates in different seasons - Add missing entityManager->clear() before verifying DB state after a POST in PrepareEliminationControllerTest and QuestionBankControllerTest - Add non-owner denial tests for BackofficeController::exportQuiz and QuizQuestionController::edit/reorder, which had IsGranted checks with no test coverage * ci: publish PHPUnit coverage to GitHub code coverage - Generate a Cobertura report alongside the existing JUnit report and upload it with actions/upload-code-coverage so coverage shows up on PRs and the default branch via GitHub's code coverage feature - Add a step to copy both reports out of the php container before publishing them, since var/ is a Docker volume (see the Dockerfile's VOLUME /app/var/) and isn't bind-mounted to the runner — this also fixes the existing JUnit report publishing step, which was silently looking at a path that never had contets on the runner * ci: fix coverage report paths and tolerate Code Quality not yet enabled - Write PHPUnit's JUnit and Cobertura reports to reports/ instead of var/, since var/ is a Docker volume (Dockerfile's VOLUME /app/var/) that isn't bind-mounted to the runner - reports written there never reached the host, which is also why the prior junit.xml publish step had nothing to read. reports/ is a plain path under the project's bind mount, so no extra copy-out step is needed - Set fail-on-error: false on the coverage upload step: it 404s until "Code Quality" is turned on for the repo under Settings > Code security > Code quality, a one-time manual step
87 lines
3.1 KiB
PHP
87 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tvdt\Tests\Controller;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use Symfony\Component\HttpFoundation\Request;
|
|
use Tvdt\Controller\EliminationController;
|
|
use Tvdt\Entity\Elimination;
|
|
use Tvdt\Helpers\Base64;
|
|
|
|
#[CoversClass(EliminationController::class)]
|
|
final class EliminationControllerTest extends AbstractControllerWebTestCase
|
|
{
|
|
private Elimination $elimination;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$quiz = $this->getQuizByName('Quiz 1');
|
|
|
|
$this->elimination = new Elimination($quiz);
|
|
$this->elimination->data = ['Tom' => Elimination::SCREEN_GREEN];
|
|
|
|
$this->entityManager->persist($this->elimination);
|
|
$this->entityManager->flush();
|
|
|
|
$this->loginAs('krtek-admin@example.org');
|
|
}
|
|
|
|
public function testIndexIsDeniedForNonOwner(): void
|
|
{
|
|
$this->loginAs('test@example.org');
|
|
|
|
$this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s', $this->elimination->id));
|
|
|
|
self::assertResponseStatusCodeSame(403);
|
|
}
|
|
|
|
public function testIndexPageLoads(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s', $this->elimination->id));
|
|
|
|
self::assertResponseIsSuccessful();
|
|
self::assertSelectorExists('form');
|
|
}
|
|
|
|
public function testIndexRedirectsToCandidateScreen(): void
|
|
{
|
|
$crawler = $this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s', $this->elimination->id));
|
|
$form = $crawler->filter('form')->form([
|
|
'elimination_enter_name[name]' => 'Tom',
|
|
]);
|
|
$this->client->submit($form);
|
|
|
|
self::assertResponseRedirects(\sprintf('/elimination/%s/%s', $this->elimination->id, Base64::base64UrlEncode('Tom')));
|
|
}
|
|
|
|
public function testCandidateScreenUnknownCandidateRedirectsWithFlash(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s/%s', $this->elimination->id, Base64::base64UrlEncode('Nobody')));
|
|
|
|
self::assertResponseRedirects(\sprintf('/elimination/%s', $this->elimination->id));
|
|
$this->client->followRedirect();
|
|
self::assertSelectorTextContains('body', 'Kon kandidaat met naam Nobody niet vinden');
|
|
}
|
|
|
|
public function testCandidateScreenCandidateNotInEliminationDataRedirectsWithFlash(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s/%s', $this->elimination->id, Base64::base64UrlEncode('Claudia')));
|
|
|
|
self::assertResponseRedirects(\sprintf('/elimination/%s', $this->elimination->id));
|
|
$this->client->followRedirect();
|
|
self::assertSelectorTextContains('body', 'Kon geen kandidaat vinden met de naam Claudia in de eliminatie');
|
|
}
|
|
|
|
public function testCandidateScreenRendersColour(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, \sprintf('/elimination/%s/%s', $this->elimination->id, Base64::base64UrlEncode('Tom')));
|
|
|
|
self::assertResponseIsSuccessful();
|
|
self::assertSelectorExists(\sprintf('#%s', Elimination::SCREEN_GREEN));
|
|
}
|
|
}
|