mirror of
https://github.com/MarijnDoeve/TijdVoorDeTest.git
synced 2026-07-13 21:35:19 +02:00
Marijn
b4a27a7c0d
* Migrate frontend to TypeScript with Deno-based tooling (#206) Compiles assets/*.ts via sensiolabs/typescript-bundle (standalone SWC binary) and adds Deno for formatting, linting, type-checking, and tests, keeping the project's no-Node/npm approach intact. Wires all four into CI, the Justfile, and the pre-commit hook. * fix: build TypeScript assets before running PHPUnit in CI The tests job ran bin/console sass:build but never typescript:build, so var/typescript/ didn't exist and any page rendering the importmap (e.g. backoffice/base.html.twig) errored during tests. * test: add regression test for backoffice navbar-toggler dead target Guards against the navbar-toggler button pointing at a collapse target (#navbarSupportedContent) that isn't rendered for the current user — the bug hit on the login page before #210 restructured the nav to always render at least one item (the Releases link) regardless of auth state. * fix: stop hand-enumerating TS files for deno check deno check assets/*.ts assets/controllers/*.ts assets/controllers/bo/*.ts was duplicated in CI and the Justfile, and silently misses any new controller subdirectory (fmt/lint/test already recurse assets/ via deno.json). Add a top-level exclude for assets/vendor/ (respected by all deno subcommands, unlike the per-task include/exclude blocks) so deno check assets/ can recurse safely instead. * fix: GitHubReleasesService date parsing and falsy release name - Move the release-mapping array_map inside the try block so a malformed published_at (or any other parse failure) degrades to the same empty-list fallback as an HTTP failure, instead of throwing uncaught out of the cache callback. - Stop treating a release literally named "0" as unnamed — the old `?:` fallback is falsy for that string and silently substituted the tag name instead. - Render release dates in UTC explicitly; Twig's date filter otherwise silently converts to the app's default timezone (Europe/Amsterdam), which could show the wrong calendar day for releases near midnight. * docs: add scope-creep-as-a-service rule to CLAUDE.md Per user instruction: when a review turns up a real bug outside the current task's scope, fix it in the same MR (with a regression test) rather than just reporting it, unless it needs a human design call.
67 lines
2.5 KiB
TypeScript
67 lines
2.5 KiB
TypeScript
import { Controller } from '@hotwired/stimulus';
|
|
import { Modal } from 'bootstrap';
|
|
import { visit } from '@hotwired/turbo';
|
|
|
|
// Bootstrap's public Modal type doesn't expose `_config` (an internal, but stable, field
|
|
// across all 5.x releases) — extend it locally rather than casting to `any` everywhere.
|
|
interface ModalWithConfig extends Modal {
|
|
_config: { backdrop: boolean | 'static'; keyboard: boolean };
|
|
}
|
|
|
|
export default class extends Controller {
|
|
static targets = ['modal', 'frame'];
|
|
|
|
declare readonly modalTarget: HTMLElement;
|
|
declare readonly frameTarget: HTMLElement;
|
|
|
|
_dirty = false;
|
|
|
|
open(event: MouseEvent): void {
|
|
event.preventDefault();
|
|
const { src, modalTitle } =
|
|
(event.currentTarget as HTMLElement).dataset;
|
|
if (modalTitle) {
|
|
const titleEl = this.modalTarget.querySelector('.modal-title');
|
|
if (titleEl) titleEl.textContent = modalTitle;
|
|
}
|
|
this.resetDirty();
|
|
this.frameTarget.innerHTML =
|
|
'<div class="modal-body text-center py-4"><div class="spinner-border" role="status"></div></div>';
|
|
this.frameTarget.removeAttribute('src');
|
|
if (src) this.frameTarget.setAttribute('src', src);
|
|
Modal.getOrCreateInstance(this.modalTarget).show();
|
|
}
|
|
|
|
frameSubmitEnd(event: CustomEvent<{ success: boolean }>): void {
|
|
if (event.detail.success) {
|
|
Modal.getOrCreateInstance(this.modalTarget).hide();
|
|
visit(window.location.href);
|
|
}
|
|
}
|
|
|
|
markDirty(): void {
|
|
if (this._dirty) return;
|
|
this._dirty = true;
|
|
// Using _config instead of preventDefault on hide.bs.modal because we need
|
|
// to block only user-triggered dismissal (backdrop click, Escape key) while
|
|
// keeping programmatic hide() working — frameSubmitEnd() calls hide() after
|
|
// a successful save and must not be blocked. _config.backdrop/keyboard is
|
|
// the correct primitive for that distinction and has been stable across all
|
|
// Bootstrap 5.x releases.
|
|
const modal = Modal.getOrCreateInstance(
|
|
this.modalTarget,
|
|
) as ModalWithConfig;
|
|
modal._config.backdrop = 'static';
|
|
modal._config.keyboard = false;
|
|
}
|
|
|
|
resetDirty(): void {
|
|
this._dirty = false;
|
|
const modal = Modal.getOrCreateInstance(
|
|
this.modalTarget,
|
|
) as ModalWithConfig;
|
|
modal._config.backdrop = true;
|
|
modal._config.keyboard = true;
|
|
}
|
|
}
|