From b37d06e2cc0a67d8819773fdf1ba9a56d3884375 Mon Sep 17 00:00:00 2001 From: "K. Nobel" Date: Thu, 19 Jan 2017 11:55:23 +0100 Subject: [PATCH 01/11] Updated queries --- website/queries/friendship.php | 5 +++-- website/queries/user.php | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/website/queries/friendship.php b/website/queries/friendship.php index 14fa6ee..a3a2fb8 100644 --- a/website/queries/friendship.php +++ b/website/queries/friendship.php @@ -2,12 +2,12 @@ require("connect.php"); function selectAllFriends($db, $userID) { - $stmt = $db->prepare(" + $stmt = $GLOBALS["db"]->prepare(" SELECT `username`, IFNULL( `profilepicture`, - 'img/notbad.png' + '../img/notbad.jpg' ) AS profilepicture, `onlinestatus`, `role` @@ -26,5 +26,6 @@ function selectAllFriends($db, $userID) { $stmt->bindParam(':userID', $userID, PDO::PARAM_INT); $stmt->execute(); + return $stmt; } \ No newline at end of file diff --git a/website/queries/user.php b/website/queries/user.php index 659e0d6..de76ff7 100644 --- a/website/queries/user.php +++ b/website/queries/user.php @@ -22,7 +22,7 @@ function selectUser($db, $userID) { `username`, IFNULL( `profilepicture`, - 'img/notbad.png' + '../img/notbad.jpg' ) AS profilepicture, `bio`, `role`, @@ -42,7 +42,7 @@ function selectUser($db, $userID) { } function selectAllUserGroups($db, $userID) { - $stmt = $db->prepare(" + $stmt = $GLOBALS["db"]->prepare(" SELECT `group_page`.`groupID`, `name`, @@ -65,7 +65,7 @@ function selectAllUserGroups($db, $userID) { } function selectAllUserPosts($db, $userID) { - $stmt = $db->prepare(" + $stmt = $GLOBALS["db"]->prepare(" SELECT `postID`, `author`, From 84719529bb091c26193c9ddc49a7fecdeb81d718 Mon Sep 17 00:00:00 2001 From: "K. Nobel" Date: Thu, 19 Jan 2017 12:01:39 +0100 Subject: [PATCH 02/11] Fixed queries and profile page. --- website/public/profile.php | 10 +++++----- website/queries/friendship.php | 2 +- website/queries/user.php | 12 ++++++------ website/views/menu.php | 2 +- website/views/profile.php | 12 +++++++----- 5 files changed, 20 insertions(+), 18 deletions(-) diff --git a/website/public/profile.php b/website/public/profile.php index 4854080..e35935b 100644 --- a/website/public/profile.php +++ b/website/public/profile.php @@ -46,12 +46,12 @@ if(empty($_GET["username"])) { return; } -$userID = getUserID($db, $_GET["username"]); +$userID = getUserID($_GET["username"]); -$user = selectUser($db, $userID); -$friends = selectAllFriends($db, $userID); -$groups = selectAllUserGroups($db, $userID); -$posts = selectAllUserPosts($db, $userID); +$user = selectUser($userID); +$profile_friends = selectAllFriends($userID); +$profile_groups = selectAllUserGroups($userID); +$posts = selectAllUserPosts($userID); ?> diff --git a/website/queries/friendship.php b/website/queries/friendship.php index a3a2fb8..f13fed5 100644 --- a/website/queries/friendship.php +++ b/website/queries/friendship.php @@ -1,7 +1,7 @@ prepare(" SELECT `username`, diff --git a/website/queries/user.php b/website/queries/user.php index de76ff7..c6e691a 100644 --- a/website/queries/user.php +++ b/website/queries/user.php @@ -1,8 +1,8 @@ prepare(" +function getUserID($username) { + $stmt = $GLOBALS["db"]->prepare(" SELECT `userID` FROM @@ -16,8 +16,8 @@ function getUserID($db, $username) { return $stmt->fetch()["userID"]; } -function selectUser($db, $userID) { - $stmt = $db->prepare(" +function selectUser($userID) { + $stmt = $GLOBALS["db"]->prepare(" SELECT `username`, IFNULL( @@ -41,7 +41,7 @@ function selectUser($db, $userID) { return $stmt->fetch(); } -function selectAllUserGroups($db, $userID) { +function selectAllUserGroups($userID) { $stmt = $GLOBALS["db"]->prepare(" SELECT `group_page`.`groupID`, @@ -64,7 +64,7 @@ function selectAllUserGroups($db, $userID) { return $stmt; } -function selectAllUserPosts($db, $userID) { +function selectAllUserPosts($userID) { $stmt = $GLOBALS["db"]->prepare(" SELECT `postID`, diff --git a/website/views/menu.php b/website/views/menu.php index 731b284..83ebfc0 100644 --- a/website/views/menu.php +++ b/website/views/menu.php @@ -13,7 +13,7 @@ $_SESSION["userID"] = 2; // Get all the friends of a user. - $friends = selectAllFriends($db, $_SESSION["userID"]); + $friends = selectAllFriends($_SESSION["userID"]); $i = 0; // Print all the users. diff --git a/website/views/profile.php b/website/views/profile.php index 395dd15..6c273a6 100644 --- a/website/views/profile.php +++ b/website/views/profile.php @@ -4,18 +4,19 @@

Als vriend toevoegen

-

-

+

()

+

Vrienden

fetch()) { - echo "" . $friend["username"] . ""; + while($friend = $profile_friends->fetch()) { + echo "${friend["username"]}"; } + if($friends->rowCount() === 0) { echo "

Deze gebruiker heeft nog geen vrienden gemaakt.

"; } @@ -27,7 +28,7 @@

Groepen

fetch()) { + while($group = $profile_groups->fetch()) { echo "${group["name"]}s logo"; } @@ -51,4 +52,5 @@ "; } ?> +

\ No newline at end of file From f535bb10ca1c169a7798fd751fbcfa0f08e156a9 Mon Sep 17 00:00:00 2001 From: "K. Nobel" Date: Thu, 19 Jan 2017 15:50:57 +0100 Subject: [PATCH 03/11] added .htaccess --- website/.htaccess | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 website/.htaccess diff --git a/website/.htaccess b/website/.htaccess new file mode 100644 index 0000000..5c0147b --- /dev/null +++ b/website/.htaccess @@ -0,0 +1,14 @@ +Options +FollowSymLinks +RewriteEngine On + +ErrorDocument 404 /error404.jpg + +RewriteCond %{SCRIPT_FILENAME} !-d +RewriteCond %{SCRIPT_FILENAME} !-f + +# Resolve .php file for extensionless php urls +RewriteRule ^([^/.]+)$ $1.php [L] + +RewriteRule ^([^/.]+)\/$ $1.php [L] + +RewriteRule ^profile/([A-z0-9]+)\/?$ profile.php?username=$1 [NC] \ No newline at end of file From 64ea5d3f68c70a51153d8288d127ebd5cacf004e Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Thu, 19 Jan 2017 15:55:28 +0100 Subject: [PATCH 04/11] Functions with validating --- website/mysql_config.xml | 7 -- website/public/login.php | 8 +-- website/public/register.php | 124 +++----------------------------- website/queries/checkInput.php | 95 ++++++++++++++++++++++++ website/views/login-view.php | 2 +- website/views/register-view.php | 4 +- 6 files changed, 113 insertions(+), 127 deletions(-) delete mode 100644 website/mysql_config.xml create mode 100644 website/queries/checkInput.php diff --git a/website/mysql_config.xml b/website/mysql_config.xml deleted file mode 100644 index de2d929..0000000 --- a/website/mysql_config.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - localhost - myhyvesbookplus - mhbp - qdtboXhCHJyL2szC - \ No newline at end of file diff --git a/website/public/login.php b/website/public/login.php index f889f2f..d8eb62a 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -15,16 +15,16 @@ // Trying to login if ($_SERVER["REQUEST_METHOD"] == "POST") { - $uname=strtolower($_POST["uname"]); // Empty username or password field if (empty($_POST["uname"]) || empty($_POST["psw"])) { $loginErr = "Gebruikersnaam of wachtwoord is niet ingevuld"; } else { - $psw=$_POST["psw"]; - $hash=getUser()["password"]; - $userid=getUser()["userID"]; + $uname = strtolower(test_input($_POST["uname"])); + $psw = test_input($_POST["psw"]); + $hash = getUser()["password"]; + $userid = getUser()["userID"]; // If there's an account, go to the profile page if(password_verify($psw, $hash)) { diff --git a/website/public/register.php b/website/public/register.php index c454d66..66d1454 100644 --- a/website/public/register.php +++ b/website/public/register.php @@ -4,7 +4,7 @@ include("../views/login_head.php"); require_once("../queries/connect.php"); include_once("../queries/register.php"); - + include_once("../queries/checkInput.php"); ?> diff --git a/website/queries/checkInput.php b/website/queries/checkInput.php new file mode 100644 index 0000000..d48e4e0 --- /dev/null +++ b/website/queries/checkInput.php @@ -0,0 +1,95 @@ + diff --git a/website/views/login-view.php b/website/views/login-view.php index 9214a89..33fa7e9 100644 --- a/website/views/login-view.php +++ b/website/views/login-view.php @@ -46,6 +46,6 @@ diff --git a/website/views/register-view.php b/website/views/register-view.php index f2b9257..b95dd81 100644 --- a/website/views/register-view.php +++ b/website/views/register-view.php @@ -108,7 +108,7 @@ From 7df182676adee1eae1cb0b2cad7f4fba4154956b Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Fri, 20 Jan 2017 10:45:53 +0100 Subject: [PATCH 05/11] Added comments to checkinput.php --- website/queries/checkInput.php | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/website/queries/checkInput.php b/website/queries/checkInput.php index d48e4e0..ceb110f 100644 --- a/website/queries/checkInput.php +++ b/website/queries/checkInput.php @@ -1,4 +1,10 @@ Date: Fri, 20 Jan 2017 11:19:54 +0100 Subject: [PATCH 06/11] Fixed include checkinput.php --- website/public/login.php | 1 + website/public/register.php | 2 +- website/queries/checkInput.php | 8 ++++---- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/website/public/login.php b/website/public/login.php index d8eb62a..c78b3ca 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -4,6 +4,7 @@ include("../views/login_head.php"); require_once("../queries/connect.php"); include_once("../queries/login.php"); + include_once("../queries/checkInput.php") ?> Date: Fri, 20 Jan 2017 11:25:38 +0100 Subject: [PATCH 07/11] fixed spelling --- website/queries/checkInput.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/queries/checkInput.php b/website/queries/checkInput.php index 25e5149..f711676 100644 --- a/website/queries/checkInput.php +++ b/website/queries/checkInput.php @@ -22,7 +22,7 @@ function checkInputChoice($variable, $option){ break; case "longerEight"; - longerEigth($variable); + longerEight($variable); break; case "email"; From db2fb1b353ce77ddf9ee5f39dc8c0ef8071c14b4 Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Fri, 20 Jan 2017 11:51:50 +0100 Subject: [PATCH 08/11] added checked already logged in function --- website/public/login.php | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/website/public/login.php b/website/public/login.php index c78b3ca..fdac086 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -10,6 +10,10 @@ + + + From dfc04be8b6c13b6df70aa16817f8960ba34df4d3 Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Fri, 20 Jan 2017 11:56:30 +0100 Subject: [PATCH 09/11] added script to window.onload --- website/public/login.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/website/public/login.php b/website/public/login.php index fdac086..086e1c6 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -11,7 +11,9 @@ session_start(); if(isset($_SESSION["userID"])){ + } // Define variables and set to empty values From 66e4fa189c559f978e88eab059aef927dd1e5ca1 Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Fri, 20 Jan 2017 11:58:33 +0100 Subject: [PATCH 10/11] added echo --- website/public/login.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/public/login.php b/website/public/login.php index 086e1c6..36e6c7d 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -11,9 +11,9 @@ session_start(); if(isset($_SESSION["userID"])){ - + " } // Define variables and set to empty values From 44bbbfeaaef03a66a3ad837d3dc8f3ea6dcd669f Mon Sep 17 00:00:00 2001 From: Joey Lai Date: Fri, 20 Jan 2017 12:01:27 +0100 Subject: [PATCH 11/11] fixed ; --- website/public/login.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/public/login.php b/website/public/login.php index 36e6c7d..65babdf 100644 --- a/website/public/login.php +++ b/website/public/login.php @@ -12,8 +12,8 @@ if(isset($_SESSION["userID"])){ echo "" + window.onload=checkLoggedIn(); + "; } // Define variables and set to empty values