From 84353046a5a6b812a93af34faf2517e660220215 Mon Sep 17 00:00:00 2001 From: Niels Zwemmer Date: Tue, 27 Jun 2017 11:11:29 +0200 Subject: [PATCH 01/44] Fixed implement runtime error for Felix. Made some minor changes to both strings.xml and ProfilePictureUploader (error when old picture not present). --- .../main/java/nl/myhyvesbookplus/tagram/MainActivity.java | 7 ++++++- .../tagram/controller/ProfilePictureUploader.java | 4 +++- .../app/src/main/res/values-nl/strings.xml | 3 +-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/MainActivity.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/MainActivity.java index 9d4e938..7c98ae4 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/MainActivity.java +++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/MainActivity.java @@ -21,7 +21,7 @@ import nl.myhyvesbookplus.tagram.controller.ProfilePictureUploader; public class MainActivity extends AppCompatActivity implements CameraFragment.OnFragmentInteractionListener, ProfilePictureUploader.ProfilePictureUpdatedListener, - DownloadClass.PostDownloadListener { + DownloadClass.PostDownloadListener, PostUploader.PostUploadListener { final static private String TAG = "MainScreen"; FirebaseAuth mAuth; @@ -130,4 +130,9 @@ public class MainActivity extends AppCompatActivity implements frag.startList(); } + + @Override + public void PostUploadComplete(Boolean success) { + + } } diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/controller/ProfilePictureUploader.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/controller/ProfilePictureUploader.java index 3264976..65e1de9 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/controller/ProfilePictureUploader.java +++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/controller/ProfilePictureUploader.java @@ -75,7 +75,9 @@ public class ProfilePictureUploader extends UploadClass { public void onComplete(@NonNull Task task) { Log.d(TAG, "onComplete: Updated profile picture"); mListener.ProfilePictureUpdated(true); - removeOldPicture(); + if (oldPicture != null) { + removeOldPicture(); + } } }); } diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml index 79c3196..e38d9a7 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml +++ b/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml @@ -29,7 +29,6 @@ Uploaden Foto opslaan mislukt. Zorg a.u.b. dat er genoeg ruimte op uw telefoon beschikbaar is. Het updaten van de profielfoto is mislukt. Controleer uw internetverbinding. - Profielfoto aan het uploaden... - Wacht a.u.b. + Profielfoto aan het uploaden… \"Niet slecht.\"s \ No newline at end of file -- 2.49.1 From 9322840d10e9febfb55aa2f285b052724c59c562 Mon Sep 17 00:00:00 2001 From: Niels Zwemmer Date: Tue, 27 Jun 2017 11:29:48 +0200 Subject: [PATCH 02/44] Minor changes to picture. --- .../main/java/nl/myhyvesbookplus/tagram/PicturePreview.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/PicturePreview.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/PicturePreview.java index 80c2dee..736e1b6 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/PicturePreview.java +++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/PicturePreview.java @@ -27,7 +27,7 @@ public class PicturePreview extends SurfaceView implements SurfaceHolder.Callbac public PicturePreview(Context context, Bitmap bmp) { super(context); - picture = Bitmap.createScaledBitmap(bmp, 1920, 1440, false); + picture = Bitmap.createScaledBitmap(bmp, bmp.getWidth() / 2, bmp.getHeight() / 2, false); // picture = Bitmap.createBitmap(bmp); setWillNotDraw(false); } @@ -52,8 +52,8 @@ public class PicturePreview extends SurfaceView implements SurfaceHolder.Callbac break; case FILTER_BW: Canvas bw = new Canvas(); - filterPicture = Bitmap.createBitmap(1920, 1440, null); -// filterPicture = Bitmap.createBitmap(picture.getWidth(), picture.getHeight(), null); +// filterPicture = Bitmap.createBitmap(1920, 1440, null); + filterPicture = Bitmap.createBitmap(picture.getWidth() / 2, picture.getHeight() / 2, Bitmap.Config.ARGB_8888); cm.setSaturation(0); filter = new ColorMatrixColorFilter(cm); paint.setColorFilter(filter); -- 2.49.1 From 2b7965ad611cad3963dd0688bda20e6bf9cb162f Mon Sep 17 00:00:00 2001 From: Marijn Jansen Date: Tue, 27 Jun 2017 12:10:56 +0200 Subject: [PATCH 03/44] Fix for timeline scrolling --- logboek/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 logboek/.gitignore diff --git a/logboek/.gitignore b/logboek/.gitignore new file mode 100644 index 0000000..3fe5e07 --- /dev/null +++ b/logboek/.gitignore @@ -0,0 +1,2 @@ +logboek.pdf + -- 2.49.1 From ab0b1056406249f19f9c89e5d61e32b5f8d6100d Mon Sep 17 00:00:00 2001 From: Marijn Jansen Date: Tue, 27 Jun 2017 12:11:52 +0200 Subject: [PATCH 04/44] Fix for timeline --- .../main/java/nl/myhyvesbookplus/tagram/TimeLineAdapter.java | 1 - .../app/src/main/res/layout/list_item_timeline.xml | 5 +++-- .../app/src/main/res/values-nl/strings.xml | 2 +- .../app/src/main/res/values/strings.xml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/TimeLineAdapter.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/TimeLineAdapter.java index 6f05305..7d4dda5 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/TimeLineAdapter.java +++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/TimeLineAdapter.java @@ -38,7 +38,6 @@ public class TimeLineAdapter extends BaseAdapter implements AdapterView.OnItemCl @Override public int getCount() { - Log.d(TAG, "getCount: " + mData.size()); return mData.size(); } diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/layout/list_item_timeline.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/layout/list_item_timeline.xml index 9e1bba4..0d2006f 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/res/layout/list_item_timeline.xml +++ b/app/MyHyvesBookPlusStagram/app/src/main/res/layout/list_item_timeline.xml @@ -7,8 +7,9 @@ + android:layout_width="wrap_content" + android:layout_gravity="center" + android:layout_height="250dp" /> Foto opslaan mislukt. Zorg a.u.b. dat er genoeg ruimte op uw telefoon beschikbaar is. Het updaten van de profielfoto is mislukt. Controleer uw internetverbinding. Profielfoto aan het uploaden… - \"Niet slecht.\"s + "\"Niet slecht.\"s " \ No newline at end of file diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml index 033a7bb..7f065d9 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml +++ b/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml @@ -22,7 +22,7 @@ profile picture Change Password Please Wait - \"Niet slecht.\"s + "\"Niet slecht.\"s " Upload Save An e-mail was sent. Please follow its instructions. -- 2.49.1 From 08849521e1d851fcccc4b8a8da39a87e6e45f73d Mon Sep 17 00:00:00 2001 From: Felix Atsma Date: Tue, 27 Jun 2017 12:37:23 +0200 Subject: [PATCH 05/44] Fix comment box clickable + prettify --- .../java/nl/myhyvesbookplus/tagram/CameraFragment.java | 2 ++ .../app/src/main/res/layout/fragment_camera.xml | 9 ++++++--- .../app/src/main/res/values-nl/strings.xml | 1 + .../app/src/main/res/values/strings.xml | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/CameraFragment.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/CameraFragment.java index 7c523a3..01bfbe9 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/CameraFragment.java +++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/CameraFragment.java @@ -153,6 +153,8 @@ public class CameraFragment extends Fragment implements PostUploader.PostUploadL (view.findViewById(R.id.upload_button)).setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { + view.findViewById(R.id.comment_box).setClickable(true); + view.findViewById(R.id.comment_box).setVisibility(View.VISIBLE); view.findViewById(R.id.comment_box).bringToFront(); } }); diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/layout/fragment_camera.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/layout/fragment_camera.xml index 27b8601..04637b3 100644 --- a/app/MyHyvesBookPlusStagram/app/src/main/res/layout/fragment_camera.xml +++ b/app/MyHyvesBookPlusStagram/app/src/main/res/layout/fragment_camera.xml @@ -74,13 +74,17 @@ android:id="@+id/comment_box" android:layout_width="match_parent" android:layout_height="wrap_content" + android:visibility="gone" + android:clickable="false" android:layout_margin="10dp" + android:padding="5dp" + android:background="@android:color/background_light" android:orientation="vertical"> + android:text="@string/comment"/>