From 3aab4631433c15d9a0e558cc19d836cc176ee60f Mon Sep 17 00:00:00 2001
From: Niels Zwemmer <niels.zwemmer@student.uva.nl>
Date: Wed, 28 Jun 2017 11:13:39 +0200
Subject: [PATCH] Added error message-shows and mail_successful/mail_failed to
 the error messages.

---
 .../java/nl/myhyvesbookplus/tagram/ProfileFragment.java     | 6 +++---
 .../app/src/main/res/values-nl/strings.xml                  | 1 +
 .../app/src/main/res/values/strings.xml                     | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/ProfileFragment.java b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/ProfileFragment.java
index 73c0388..16378c1 100644
--- a/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/ProfileFragment.java
+++ b/app/MyHyvesBookPlusStagram/app/src/main/java/nl/myhyvesbookplus/tagram/ProfileFragment.java
@@ -146,7 +146,7 @@ public class ProfileFragment extends Fragment implements View.OnClickListener {
             try {
                 photoFile = createImageFile();
             } catch (IOException ex) {
-                Toast.makeText(getActivity(), getString(R.string.image_save_error), Toast.LENGTH_LONG);
+                Toast.makeText(getActivity(), getString(R.string.image_save_error), Toast.LENGTH_LONG).show();
             }
             if (photoFile != null) {
                 Uri photoURI = FileProvider.getUriForFile(getActivity(),
@@ -213,8 +213,8 @@ public class ProfileFragment extends Fragment implements View.OnClickListener {
                         @Override
                         public void onComplete(@NonNull Task<Void> task) {
                             Toast.makeText(getActivity(), task.isSuccessful()
-                                            ? "An e-mail was sent, please follow its instructions."
-                                            : "An error occurred, please check internet connection.",
+                                            ? getString(R.string.mail_successful)
+                                            : getString(R.string.mail_failed),
                                     Toast.LENGTH_SHORT).show();
                         }
                     });
diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml
index 57fc504..ff4209c 100644
--- a/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml
+++ b/app/MyHyvesBookPlusStagram/app/src/main/res/values-nl/strings.xml
@@ -31,4 +31,5 @@
     <string name="update_profile_pic_error">Het updaten van de profielfoto is mislukt. Controleer uw internetverbinding.</string>
     <string name="upload_profile_pic">Profielfoto aan het uploaden…</string>
     <string name="niet_slecht">"\"Niet slecht.\"s "</string>
+    <string name="mail_success">An e-mail was sent, please follow its instructions.</string>
 </resources>
\ No newline at end of file
diff --git a/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml b/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml
index 7f065d9..39d347b 100644
--- a/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml
+++ b/app/MyHyvesBookPlusStagram/app/src/main/res/values/strings.xml
@@ -29,5 +29,5 @@
     <string name="mail_failed">An error occurred. Please check internet connection.</string>
     <string name="image_save_error">Saving image to storage failed. Please make sure there is space available on the device.</string>
     <string name="update_profile_pic_error">Updating the profile picture failed. Please check network connection.</string>
-    <string name="upload_profile_pic">Uploading profile picture...</string>
+    <string name="upload_profile_pic">Uploading profile picture…</string>
 </resources>