mirror of
https://github.com/MarijnDoeve/TijdVoorDeTest.git
synced 2026-07-13 13:25:19 +02:00
Marijn
b4a27a7c0d
* Migrate frontend to TypeScript with Deno-based tooling (#206) Compiles assets/*.ts via sensiolabs/typescript-bundle (standalone SWC binary) and adds Deno for formatting, linting, type-checking, and tests, keeping the project's no-Node/npm approach intact. Wires all four into CI, the Justfile, and the pre-commit hook. * fix: build TypeScript assets before running PHPUnit in CI The tests job ran bin/console sass:build but never typescript:build, so var/typescript/ didn't exist and any page rendering the importmap (e.g. backoffice/base.html.twig) errored during tests. * test: add regression test for backoffice navbar-toggler dead target Guards against the navbar-toggler button pointing at a collapse target (#navbarSupportedContent) that isn't rendered for the current user — the bug hit on the login page before #210 restructured the nav to always render at least one item (the Releases link) regardless of auth state. * fix: stop hand-enumerating TS files for deno check deno check assets/*.ts assets/controllers/*.ts assets/controllers/bo/*.ts was duplicated in CI and the Justfile, and silently misses any new controller subdirectory (fmt/lint/test already recurse assets/ via deno.json). Add a top-level exclude for assets/vendor/ (respected by all deno subcommands, unlike the per-task include/exclude blocks) so deno check assets/ can recurse safely instead. * fix: GitHubReleasesService date parsing and falsy release name - Move the release-mapping array_map inside the try block so a malformed published_at (or any other parse failure) degrades to the same empty-list fallback as an HTTP failure, instead of throwing uncaught out of the cache callback. - Stop treating a release literally named "0" as unnamed — the old `?:` fallback is falsy for that string and silently substituted the tag name instead. - Render release dates in UTC explicitly; Twig's date filter otherwise silently converts to the app's default timezone (Europe/Amsterdam), which could show the wrong calendar day for releases near midnight. * docs: add scope-creep-as-a-service rule to CLAUDE.md Per user instruction: when a review turns up a real bug outside the current task's scope, fix it in the same MR (with a regression test) rather than just reporting it, unless it needs a human design call.
134 lines
4.9 KiB
PHP
134 lines
4.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tvdt\Tests\Service;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\TestCase;
|
|
use Safe\DateTimeImmutable;
|
|
use Symfony\Component\Cache\Adapter\ArrayAdapter;
|
|
use Symfony\Component\HttpClient\MockHttpClient;
|
|
use Symfony\Component\HttpClient\Response\MockResponse;
|
|
use Tvdt\Service\GitHubReleasesService;
|
|
|
|
#[CoversClass(GitHubReleasesService::class)]
|
|
final class GitHubReleasesServiceTest extends TestCase
|
|
{
|
|
public function testGetReleasesMapsGitHubResponse(): void
|
|
{
|
|
$body = json_encode([
|
|
[
|
|
'tag_name' => 'v0.8.0',
|
|
'name' => 'v0.8.0',
|
|
'published_at' => '2026-07-12T10:00:00Z',
|
|
'body' => "## Added\n- Something new",
|
|
'html_url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.8.0',
|
|
],
|
|
], \JSON_THROW_ON_ERROR);
|
|
|
|
$httpClient = new MockHttpClient([new MockResponse((string) $body, ['response_headers' => ['content-type' => 'application/json']])]);
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$releases = $subject->getReleases();
|
|
|
|
$this->assertEquals([
|
|
'tagName' => 'v0.8.0',
|
|
'name' => 'v0.8.0',
|
|
'publishedAt' => new DateTimeImmutable('2026-07-12T10:00:00Z'),
|
|
'body' => "## Added\n- Something new",
|
|
'url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.8.0',
|
|
], $releases[0]);
|
|
}
|
|
|
|
public function testGetReleasesReturnsEmptyArrayOnHttpFailure(): void
|
|
{
|
|
$httpClient = new MockHttpClient(static fn (): MockResponse => new MockResponse('', ['http_code' => 500]));
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$this->assertSame([], $subject->getReleases());
|
|
}
|
|
|
|
public function testHttpFailureIsNotCached(): void
|
|
{
|
|
$requestCount = 0;
|
|
$httpClient = new MockHttpClient(static function () use (&$requestCount): MockResponse {
|
|
++$requestCount;
|
|
|
|
return new MockResponse('', ['http_code' => 500]);
|
|
});
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$subject->getReleases();
|
|
$subject->getReleases();
|
|
|
|
$this->assertSame(2, $requestCount);
|
|
}
|
|
|
|
public function testGetReleasesReturnsEmptyArrayOnUnparseablePublishedAt(): void
|
|
{
|
|
$body = json_encode([
|
|
[
|
|
'tag_name' => 'v0.8.0',
|
|
'name' => 'v0.8.0',
|
|
'published_at' => 'not-a-valid-date',
|
|
'body' => 'Some release notes',
|
|
'html_url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.8.0',
|
|
],
|
|
], \JSON_THROW_ON_ERROR);
|
|
|
|
$httpClient = new MockHttpClient([new MockResponse((string) $body, ['response_headers' => ['content-type' => 'application/json']])]);
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$this->assertSame([], $subject->getReleases());
|
|
}
|
|
|
|
public function testGetReleasesKeepsALiteralZeroReleaseName(): void
|
|
{
|
|
$body = json_encode([
|
|
[
|
|
'tag_name' => 'v0.9.0',
|
|
'name' => '0',
|
|
'published_at' => '2026-07-12T10:00:00Z',
|
|
'body' => 'Some release notes',
|
|
'html_url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.9.0',
|
|
],
|
|
], \JSON_THROW_ON_ERROR);
|
|
|
|
$httpClient = new MockHttpClient([new MockResponse((string) $body, ['response_headers' => ['content-type' => 'application/json']])]);
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$releases = $subject->getReleases();
|
|
|
|
$this->assertSame('0', $releases[0]['name']);
|
|
}
|
|
|
|
public function testGetReleasesSortsNewestFirst(): void
|
|
{
|
|
$body = json_encode([
|
|
[
|
|
'tag_name' => 'v0.7.0',
|
|
'name' => 'v0.7.0',
|
|
'published_at' => '2026-07-10T10:00:00Z',
|
|
'body' => 'Older release',
|
|
'html_url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.7.0',
|
|
],
|
|
[
|
|
'tag_name' => 'v0.8.0',
|
|
'name' => 'v0.8.0',
|
|
'published_at' => '2026-07-12T10:00:00Z',
|
|
'body' => 'Newer release',
|
|
'html_url' => 'https://github.com/MarijnDoeve/TijdVoorDeTest/releases/tag/v0.8.0',
|
|
],
|
|
], \JSON_THROW_ON_ERROR);
|
|
|
|
$httpClient = new MockHttpClient([new MockResponse((string) $body, ['response_headers' => ['content-type' => 'application/json']])]);
|
|
$subject = new GitHubReleasesService($httpClient, new ArrayAdapter());
|
|
|
|
$releases = $subject->getReleases();
|
|
|
|
$this->assertSame('v0.8.0', $releases[0]['tagName']);
|
|
$this->assertSame('v0.7.0', $releases[1]['tagName']);
|
|
}
|
|
}
|