mirror of
https://github.com/MarijnDoeve/TijdVoorDeTest.git
synced 2026-07-11 12:28:23 +02:00
Marijn
2fd15ba8fa
* test: expand coverage, dedupe data-driven tests, extract shared WebTestCase base - Add #[CoversClass] to Base64Test and FilenameSanitizerTest - Merge near-duplicate test methods into #[DataProvider] cases across ResetPasswordControllerTest, SettingsControllerTest, ClaimSeasonCommandTest, FilenameSanitizerTest, Base64Test, and SeasonRepositoryTest - Add integration tests for previously untested controllers: public QuizController (quiz-taking flow), LoginController, RegistrationController, EliminationController, and PrepareEliminationController - Add unit tests for Elimination and BankQuestion entity logic - Extract shared WebTestCase setup/helpers (client, entityManager, login, entity lookups, CSRF token scraping) into AbstractControllerWebTestCase, removing duplicated boilerplate from all 14 WebTestCase files * test: address PR review feedback - Scope AbstractControllerWebTestCase::getCandidate/getQuizByName by season code (both Candidate and Quiz are only unique per season, not system-wide) and add a CandidateRepository regression test guarding against same-named candidates in different seasons - Add missing entityManager->clear() before verifying DB state after a POST in PrepareEliminationControllerTest and QuestionBankControllerTest - Add non-owner denial tests for BackofficeController::exportQuiz and QuizQuestionController::edit/reorder, which had IsGranted checks with no test coverage * ci: publish PHPUnit coverage to GitHub code coverage - Generate a Cobertura report alongside the existing JUnit report and upload it with actions/upload-code-coverage so coverage shows up on PRs and the default branch via GitHub's code coverage feature - Add a step to copy both reports out of the php container before publishing them, since var/ is a Docker volume (see the Dockerfile's VOLUME /app/var/) and isn't bind-mounted to the runner — this also fixes the existing JUnit report publishing step, which was silently looking at a path that never had contets on the runner * ci: fix coverage report paths and tolerate Code Quality not yet enabled - Write PHPUnit's JUnit and Cobertura reports to reports/ instead of var/, since var/ is a Docker volume (Dockerfile's VOLUME /app/var/) that isn't bind-mounted to the runner - reports written there never reached the host, which is also why the prior junit.xml publish step had nothing to read. reports/ is a plain path under the project's bind mount, so no extra copy-out step is needed - Set fail-on-error: false on the coverage upload step: it 404s until "Code Quality" is turned on for the repo under Settings > Code security > Code quality, a one-time manual step
91 lines
3.1 KiB
PHP
91 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tvdt\Tests\Controller;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use Symfony\Component\HttpFoundation\Request;
|
|
use SymfonyCasts\Bundle\VerifyEmail\VerifyEmailHelperInterface;
|
|
use Tvdt\Controller\RegistrationController;
|
|
|
|
#[CoversClass(RegistrationController::class)]
|
|
final class RegistrationControllerTest extends AbstractControllerWebTestCase
|
|
{
|
|
public function testRegisterPageLoadsWhenNotAuthenticated(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, '/register');
|
|
|
|
self::assertResponseIsSuccessful();
|
|
self::assertSelectorExists('form');
|
|
}
|
|
|
|
public function testRegisterRedirectsToBackofficeWhenAlreadyAuthenticated(): void
|
|
{
|
|
$this->loginAs('test@example.org');
|
|
|
|
$this->client->request(Request::METHOD_GET, '/register');
|
|
|
|
self::assertResponseRedirects('/backoffice/');
|
|
}
|
|
|
|
public function testRegisterCreatesUserSendsConfirmationAndLogsIn(): void
|
|
{
|
|
$crawler = $this->client->request(Request::METHOD_GET, '/register');
|
|
$form = $crawler->filter('form')->form([
|
|
'registration_form[email]' => 'newuser@example.org',
|
|
'registration_form[plainPassword][first]' => 'NewPass123!',
|
|
'registration_form[plainPassword][second]' => 'NewPass123!',
|
|
]);
|
|
$this->client->submit($form);
|
|
|
|
self::assertResponseRedirects('/backoffice/');
|
|
self::assertEmailCount(1);
|
|
|
|
$this->entityManager->clear();
|
|
$user = $this->getUserByEmail('newuser@example.org');
|
|
$this->assertFalse($user->isVerified);
|
|
}
|
|
|
|
public function testVerifyEmailWithoutIdRedirectsToRegister(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, '/verify/email');
|
|
|
|
self::assertResponseRedirects('/register');
|
|
}
|
|
|
|
public function testVerifyEmailWithUnknownIdRedirectsToRegister(): void
|
|
{
|
|
$this->client->request(Request::METHOD_GET, '/verify/email', ['id' => '00000000-0000-0000-0000-000000000000']);
|
|
|
|
self::assertResponseRedirects('/register');
|
|
}
|
|
|
|
public function testVerifyEmailWithValidSignatureMarksUserVerified(): void
|
|
{
|
|
$user = $this->getUserByEmail('test@example.org');
|
|
$this->assertFalse($user->isVerified);
|
|
|
|
/** @var VerifyEmailHelperInterface $helper */
|
|
$helper = self::getContainer()->get(VerifyEmailHelperInterface::class);
|
|
$signature = $helper->generateSignature('tvdt_verify_email', $user->id->toRfc4122(), $user->email, ['id' => $user->id]);
|
|
|
|
$this->client->request(Request::METHOD_GET, $signature->getSignedUrl());
|
|
|
|
self::assertResponseRedirects('/backoffice/');
|
|
|
|
$this->entityManager->clear();
|
|
$updatedUser = $this->getUserByEmail('test@example.org');
|
|
$this->assertTrue($updatedUser->isVerified);
|
|
}
|
|
|
|
public function testVerifyEmailWithInvalidSignatureShowsErrorAndRedirects(): void
|
|
{
|
|
$user = $this->getUserByEmail('test@example.org');
|
|
|
|
$this->client->request(Request::METHOD_GET, '/verify/email', ['id' => (string) $user->id, 'expires' => '9999999999', 'signature' => 'invalid']);
|
|
|
|
self::assertResponseRedirects('/register');
|
|
}
|
|
}
|