Fix question order (#99)

.gitignore

@@ -68,6 +68,19 @@ Icon
 # Thumbnails
 ._*
 
+# IDEs
+/.idea/
+/.vscode/
+
+# Junie
+!/.junie/
+/.junie/memory/
+/.junie/plans/
+
+# Windows
+Thumbs.db
+Desktop.ini
+
 # Files that might appear in the root of a volume
 .DocumentRevisions-V100
 .fseventsd

.junie/GUIDELINES.md

@@ -1 +0,0 @@
-AGENTS.md

AGENTS.md

@@ -61,6 +61,19 @@ The project uses `just` as the primary task runner. Always prefer `just` command
 - CSS/Sass is in `assets/styles/`.
 - Assets are compiled on-the-fly or mapped; do not look for a `node_modules` folder.
 
+## Key Components
+### Controllers
+- **Backoffice**: Located in `src/Controller/Backoffice`, handles season and quiz management.
+- **Quiz**: `src/Controller/QuizController` handles the candidate-facing side of quizzes.
+- **Elimination**: `src/Controller/EliminationController` handles elimination screens.
+
+### Services
+- **QuizSpreadsheetService**: Handles importing quizzes from XLSX files.
+
+### Base Classes & Enums
+- **AbstractController**: Base class for all controllers, containing common regexes and flash helpers.
+- **FlashType Enum**: Used for consistent flash messaging (`FlashType::Success`, `FlashType::Danger`, etc.).
+
 ## Key Files
 - `composer.json`: Dependency management.
 - `importmap.php`: JavaScript module mapping.

src/Controller/LoginController.php

@@ -8,6 +8,7 @@ use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Attribute\AsController;
 use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
+use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
 use Symfony\Contracts\Translation\TranslatorInterface;
 use Tvdt\Enum\FlashType;
@@ -20,6 +21,10 @@ final class LoginController extends AbstractController
     #[Route(path: '/login', name: 'tvdt_login_login')]
     public function login(): Response
     {
+        if ($this->getUser() instanceof UserInterface) {
+            return $this->redirectToRoute('tvdt_backoffice_index');
+        }
+
         // get the login error if there is one
         $error = $this->authenticationUtils->getLastAuthenticationError();
         // last username entered by the user

src/Controller/RegistrationController.php

@@ -15,6 +15,7 @@ use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Mailer\Exception\TransportExceptionInterface;
 use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
 use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 use SymfonyCasts\Bundle\VerifyEmail\Exception\VerifyEmailExceptionInterface;
 use Tvdt\Entity\User;
@@ -30,6 +31,10 @@ final class RegistrationController extends AbstractController
     public function register(
         Request $request,
     ): Response {
+        if ($this->getUser() instanceof UserInterface) {
+            return $this->redirectToRoute('tvdt_backoffice_index');
+        }
+
         $user = new User();
         $form = $this->createForm(RegistrationFormType::class, $user);
         $form->handleRequest($request);

src/Repository/QuestionRepository.php

@@ -30,6 +30,7 @@ class QuestionRepository extends ServiceEntityRepository
                 and q1.quiz = :quiz
             )
             and qz = :quiz
+            order by q.ordering
             DQL)
             ->setMaxResults(1)
             ->setParameter('candidate', $candidate)

src/Service/QuizSpreadsheetService.php

@@ -95,11 +95,15 @@ class QuizSpreadsheetService
             $arrCounter = 1;
 
             while (true) {
-                if (null === $questionArr[$arrCounter]) {
-                    if (1 === $answerCounter) {
-                        $errors[] = \sprintf('Question %d has no answers', $answerCounter);
-                    }
+                try {
+                    if (null === $questionArr[$arrCounter]) {
+                        if (1 === $answerCounter) {
+                            $errors[] = \sprintf('Question %d has no answers', $answerCounter);
+                        }
 
+                        break;
+                    }
+                } catch (\ErrorException) {
                     break;
                 }
 
@@ -130,6 +134,6 @@ class QuizSpreadsheetService
 
     private function isSpreadsheetFile(File $file): bool
     {
-        return 'xlsx' === $file->getExtension();
+        return 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' === $file->getMimeType();
     }
 }