2 Commits

Author	SHA1	Message	Date
Marijn	0ee15e3cbb	feat: add GDPR data export (download data) button (#198) ... * feat: add GDPR data export (download data) button Wires up the previously disabled "Download data" button on the settings page. Downloads a zip with a profile.xlsx (account + owned seasons), and per owned season a folder with each quiz's xlsx (questions, results, eliminations tabs) and a candidates.xlsx (candidates + season info tabs). Soft-deleted rows are included and flagged so the export reflects everything the app still holds about the user. * feat: include question bank in GDPR data export Adds a question-bank.xlsx per season folder with Questions (bank questions, answers, reusable/complete flags, labels, and which quizzes they've been used in) and Labels tabs, since BankQuestion/BankAnswer content was previously missing from the export. * fix: hard-delete quiz/audit-log data when deleting an account QuizCandidate, GivenAnswer, and Elimination are Gedmo\SoftDeleteable, so cascading their removal through Season -> Quiz/Candidate only set deletedAt instead of physically deleting the row. Since Candidate and Answer are hard-deleted via orphanRemoval, this broke their foreign keys and rolled back the entire account deletion whenever a candidate had actually participated in a quiz. Bulk DQL deletes now purge these rows before the cascade runs. Also purge BankQuestion audit-log rows (ext_log_entries), which store the editor's username/email but aren't foreign-keyed to the entity they log, so they were never cleaned up and would otherwise keep a deleted user's email around indefinitely. * style: make the download data button primary (blue) * feat: add raw answers crosstab to quiz export Adds a "Raw answers" tab to each quiz xlsx: one row per candidate, one column per question, with the given answer text in each cell — the raw data behind the aggregated Results tab. * i18n: translate new settings page string to Dutch * refactor: sanitize filenames with Symfony's AsciiSlugger instead of a hand-rolled regex Extracts a shared Tvdt\Helpers\FilenameSanitizer (backed by symfony/string's AsciiSlugger) and uses it everywhere user-controlled text (season/quiz names, account email) ends up in a zip entry path or a downloaded filename. AsciiSlugger is allowlist-based (only A-Z/0-9 survive; everything else, including unicode and path-traversal sequences, is folded or stripped) rather than a denylist of "unsafe" characters, and it's an officially maintained Symfony component already present as a transitive dependency. Also fixes BackofficeController::exportQuiz(), a pre-existing endpoint that built its Content-Disposition filename directly from an unsanitized quiz name — the same class of risk the data export already guarded against. Naming note: sanitized names are now slugs (spaces become dashes, unicode is ASCII-transliterated), e.g. "Krtek Weekend" -> "Krtek-Weekend". * fix: check ZipArchive open/close results and clean up temp files on failure Addresses CodeRabbit findings on the GDPR export: - ZipArchive::open() and close() can both return false without throwing; neither was checked, so a failure silently produced an empty or corrupt zip, and the temp zip path was never cleaned up on a mid-build exception. - writeToTempFile() leaked its tempnam()'d file if Writer\Xlsx::save() threw before the caller could track it for cleanup. * fix: drop public link identifier from the candidates export sheet The nameHash is a public quiz-access token, not something a data export should hand out — remove it from candidates.xlsx. * feat: add Quiz info tab covering dropouts, finalization, and disabled questions An entity-by-entity audit of the export vs. delete flows found the delete flow fully covered, but three Quiz/Question fields missing from the export: dropouts, finalizedAt, and Question.enabled. Adds a new "Quiz info" tab (first sheet) to each quiz's xlsx with this data, without touching the shared fillQuestionsSheet() used by the existing single-quiz template export/import feature. Deliberately left out per user decision: the BankQuestion audit log (would leak other owners' emails, consistent with hiding co-owner identities elsewhere in this export) and a few low-value timestamp fields already covered by existing Started/time-taken columns. * feat: require a confirmed email before exporting data Antispam measure: both the full data export (SettingsController::downloadData) and the single-quiz export (BackofficeController::exportQuiz) now redirect with a flash warning instead of exporting when the account's email isn't verified yet. Adds a matching hint on the settings page next to the download button.	2026-07-09 20:28:10 +00:00
Marijn	404c0dcc26	Summer cleanup: XLSX export, WIDM-style quiz UI, CSS fixes (#162) ... * Add CLAUDE.md, replace Makefile with Justfile, remove .junie - Add CLAUDE.md with project overview, commands, architecture, and domain entity docs - Remove Makefile in favour of the existing Justfile - Remove .junie/AGENTS.md (knowledge transferred to CLAUDE.md) - Update .gitignore: drop .junie/ entries, add .claude/settings.local.json - Minor doc fixes in config/reference.php (typo, type correction) * Clean up templates and CSS - season.html.twig: remove dead empty column, drop redundant flex-row - tab_overview.html.twig: extract Twig macro for confirm modals, fix duplicate aria-labelledby IDs - tab_result.html.twig: remove dead comment, replace inline widths with CSS classes, simplify nested row/col forms to d-flex gap-1 - backoffice.scss: add col-result-xs/sm/md column width classes - quiz.scss: replace broken display:grid + justify-self:center with flexbox centering * Implement quizToXlsx() export and add export button - QuizSpreadsheetService: implement quizToXlsx() as the inverse of fillQuizFromArray() — writes quiz questions and answers to XLSX using the same column layout as the import template - BackofficeController: add exportQuiz() action at GET /backoffice/quiz/{quiz}/export - tab_overview.html.twig: add Export to XLSX button in Quick actions * Add unit tests for QuizSpreadsheetService 7 tests covering generateTemplate(), quizToXlsx(), and xlsxToQuiz(): - valid XLSX output and MIME type - template without example reimports as empty - template example data survives a reimport - round-trip (export → reimport) preserves questions, answers, and correct flags - empty quiz exports and reimports cleanly - invalid MIME type throws InvalidArgumentException - question with no answers throws SpreadsheetDataException with error list * Fix quiz page vertical centering regression The CSS cleanup broke vertical centering: flex on body causes main to stretch full-width; place-items:center on a grid body only centers items within their auto-sized track (not the track within body). Fix: move background/color to html (full-viewport grid that centers body), give body height:100% + display:grid + align-content:center (centers the content track within full-height body) + justify-self:center (shrink-wraps body width). Matches production behavior exactly. * Improve quiz page layouts: WIDM-style answers and responsive centering - Add green square answer buttons styled after the TV show - Two-column answer grid for 6+ answers, single column on mobile - fit-content centering for question pages so block matches question width - Narrow fixed-width centering for form pages (enter name, select season) * Use HeaderUtils::makeDisposition() for safe Content-Disposition filename * Fix quizToXlsx to support unlimited answers and add header count tests - Replace hardcoded 6-column arrays with dynamic Coordinate arithmetic - Write data rows first to determine max answer count, write headers last - Replace try/catch ErrorException in fillQuizFromArray with array_key_exists - Add data-provider test covering 2, 6, 7, and 10 answers - Add cross-question max-header and 7-answer round-trip tests * Fix Sass healthcheck * Improve quiz layout: add fixed topbar, include navigation, and clean up unused elements - Add `.quiz-topbar` with fixed positioning and spacing in `quiz.scss` - Update `base.html.twig` to include `quiz/nav.html.twig` in a new `nav` block - Remove unused "Manage Quiz" button from `select_season.html.twig` * Refactor generateTemplate to reuse quizToXlsx and add second example question - generateTemplate now builds an in-memory Quiz entity and delegates to quizToXlsx, eliminating duplicate spreadsheet-building logic - Adds a second example question "Wie is de mol?" with 10 Dutch names (5 male, 5 female) to better illustrate the import format - Updates tests to assert both example questions and adds a test for the blank-row halt behaviour in fillQuizFromArray (achieving 100% coverage) * Move PHPUnit cache to /tmp to avoid writing into the mounted volume * Update src/Service/QuizSpreadsheetService.php Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	2026-07-02 20:25:02 +00:00