Some tests

src/Command/AddSettingsCommand.php

@@ -1,41 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tvdt\Command;
-
-use Doctrine\ORM\EntityManagerInterface;
-use Symfony\Component\Console\Attribute\AsCommand;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Console\Style\SymfonyStyle;
-use Tvdt\Entity\SeasonSettings;
-use Tvdt\Repository\SeasonRepository;
-
-#[AsCommand(
-    name: 'tvdt:add-settings',
-    description: 'Add a short description for your command',
-)]
-readonly class AddSettingsCommand
-{
-    public function __construct(private SeasonRepository $seasonRepository, private EntityManagerInterface $entityManager) {}
-
-    public function __invoke(InputInterface $input, OutputInterface $output): int
-    {
-        $io = new SymfonyStyle($input, $output);
-
-        foreach ($this->seasonRepository->findAll() as $season) {
-            if (null !== $season->settings) {
-                continue;
-            }
-
-            $io->text('Adding settings to season : '.$season->seasonCode);
-            $season->settings = new SeasonSettings();
-        }
-
-        $this->entityManager->flush();
-
-        return Command::SUCCESS;
-    }
-}

src/Command/ClaimSeasonCommand.php

@@ -8,8 +8,6 @@ use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\Console\Attribute\Argument;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Tvdt\Repository\SeasonRepository;
 use Tvdt\Repository\UserRepository;
@@ -18,7 +16,7 @@ use Tvdt\Repository\UserRepository;
     name: 'tvdt:claim-season',
     description: 'Give a user owner rights on a season',
 )]
-readonly class ClaimSeasonCommand
+final readonly class ClaimSeasonCommand
 {
     public function __construct(private UserRepository $userRepository, private SeasonRepository $seasonRepository, private EntityManagerInterface $entityManager) {}
 
@@ -27,13 +25,10 @@ readonly class ClaimSeasonCommand
         string $seasonCode,
         #[Argument]
         string $email,
-        InputInterface $input,
-        OutputInterface $output,
+        SymfonyStyle $io,
     ): int {
-        $io = new SymfonyStyle($input, $output);
-
         try {
-            $season = $this->seasonRepository->findOneBy(['seasonCode' => $seasonCode]);
+            $season = $this->seasonRepository->findOneBySeasonCode($seasonCode);
             if (null === $season) {
                 throw new \InvalidArgumentException('Season not found');
             }

src/Command/MakeAdminCommand.php

@@ -7,8 +7,6 @@ namespace Tvdt\Command;
 use Symfony\Component\Console\Attribute\Argument;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Tvdt\Repository\UserRepository;
 
@@ -16,17 +14,15 @@ use Tvdt\Repository\UserRepository;
     name: 'tvdt:make-admin',
     description: 'Give a user the role admin',
 )]
-readonly class MakeAdminCommand
+final readonly class MakeAdminCommand
 {
     public function __construct(private UserRepository $userRepository) {}
 
     public function __invoke(
         #[Argument]
         string $email,
-        InputInterface $input,
-        OutputInterface $output,
+        SymfonyStyle $io,
     ): int {
-        $io = new SymfonyStyle($input, $output);
         try {
             $this->userRepository->makeAdmin($email);
         } catch (\InvalidArgumentException) {

src/Controller/QuizController.php

@@ -4,6 +4,7 @@ declare(strict_types=1);
 
 namespace Tvdt\Controller;
 
+use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Attribute\AsController;
@@ -30,7 +31,7 @@ use Tvdt\Repository\SeasonRepository;
 #[AsController]
 final class QuizController extends AbstractController
 {
-    public function __construct(private readonly TranslatorInterface $translator) {}
+    public function __construct(private readonly TranslatorInterface $translator, private readonly EntityManagerInterface $entityManager) {}
 
     #[Route(path: '/', name: 'tvdt_quiz_select_season', methods: ['GET', 'POST'])]
     public function selectSeason(Request $request, SeasonRepository $seasonRepository): Response
@@ -110,7 +111,8 @@ final class QuizController extends AbstractController
             }
 
             $givenAnswer = new GivenAnswer($candidate, $answer->question->quiz, $answer);
-            $givenAnswerRepository->save($givenAnswer);
+            $this->entityManager->persist($givenAnswer);
+            $this->entityManager->flush();
 
             return $this->redirectToRoute('tvdt_quiz_quiz_page', ['seasonCode' => $season->seasonCode, 'nameHash' => $nameHash]);
         }

src/DataFixtures/KrtekFixtures.php

@@ -5,6 +5,7 @@ declare(strict_types=1);
 namespace Tvdt\DataFixtures;
 
 use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\Bundle\FixturesBundle\FixtureGroupInterface;
 use Doctrine\Persistence\ObjectManager;
 use Tvdt\Entity\Answer;
 use Tvdt\Entity\Candidate;
@@ -12,8 +13,13 @@ use Tvdt\Entity\Question;
 use Tvdt\Entity\Quiz;
 use Tvdt\Entity\Season;
 
-class KrtekFixtures extends Fixture
+final class KrtekFixtures extends Fixture implements FixtureGroupInterface
 {
+    public static function getGroups(): array
+    {
+        return ['test', 'dev'];
+    }
+
     public function load(ObjectManager $manager): void
     {
         $season = new Season();

src/DataFixtures/TestFixtures.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tvdt\DataFixtures;
+
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\Bundle\FixturesBundle\FixtureGroupInterface;
+use Doctrine\Persistence\ObjectManager;
+use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
+use Tvdt\Entity\User;
+
+final class TestFixtures extends Fixture implements FixtureGroupInterface
+{
+    public function __construct(
+        private UserPasswordHasherInterface $passwordHasher,
+    ) {}
+
+    public static function getGroups(): array
+    {
+        return ['test'];
+    }
+
+    public function load(ObjectManager $manager): void
+    {
+        $user = new User();
+        $user->email = 'test@example.org';
+        $user->password = $this->passwordHasher->hashPassword($user, 'test1234');
+
+        $manager->persist($user);
+        $manager->flush();
+    }
+}

src/Repository/CandidateRepository.php

@@ -43,15 +43,6 @@ class CandidateRepository extends ServiceEntityRepository
             ->getOneOrNullResult();
     }
 
-    public function save(Candidate $candidate, bool $flush = true): void
-    {
-        $this->getEntityManager()->persist($candidate);
-
-        if ($flush) {
-            $this->getEntityManager()->flush();
-        }
-    }
-
     /**
      * @throws DatetimeException
      *

src/Repository/GivenAnswerRepository.php

@@ -17,13 +17,4 @@ class GivenAnswerRepository extends ServiceEntityRepository
     {
         parent::__construct($registry, GivenAnswer::class);
     }
-
-    public function save(GivenAnswer $givenAnswer, bool $flush = true): void
-    {
-        $this->getEntityManager()->persist($givenAnswer);
-
-        if ($flush) {
-            $this->getEntityManager()->flush();
-        }
-    }
 }

src/Repository/SeasonRepository.php

@@ -19,6 +19,17 @@ class SeasonRepository extends ServiceEntityRepository
         parent::__construct($registry, Season::class);
     }
 
+    public function findOneBySeasonCode(string $seasonCode): ?Season
+    {
+        return $this->getEntityManager()->createQuery(<<<DQL
+            select s from Tvdt\Entity\Season s
+            where s.seasonCode = :seasonCode
+            DQL)
+            ->setParameter(':seasonCode', $seasonCode)
+            ->setMaxResults(1)
+            ->getOneOrNullResult();
+    }
+
     /** @return list<Season> Returns an array of Season objects */
     public function getSeasonsForUser(User $user): array
     {