Marijn/TijdVoorDeTest
1
0
Fork 0
mirror of https://github.com/MarijnDoeve/TijdVoorDeTest.git synced 2026-07-08 00:20:15 +02:00
Code Issues Packages Projects Releases Activity

feat: replace fetch-based modal forms with Turbo Frames (#181)

Browse Source 
Enable @hotwired/turbo with Drive explicitly disabled, then migrate the
bo--modal-form Stimulus controller (custom fetch + X-Modal-Request pattern)
to a thin bo--modal controller that lets Turbo handle HTTP and DOM swap.
Adds frame templates for quiz questions and bank questions; controllers now
detect Turbo-Frame header instead of X-Modal-Request.
This commit is contained in:
Marijn Doeve
2026-07-06 23:13:55 +02:00
parent 3b6ff680e5
commit cb577d60d3
12 changed files with 175 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Controller/Backoffice/QuestionBankController.php
+10 -12
View File
@@ -88,7 +88,7 @@ class QuestionBankController extends AbstractController
{
$bankQuestion = new BankQuestion();
$isModalRequest = $request->headers->has('X-Modal-Request');
$isTurboFrame = $request->headers->has('Turbo-Frame');
$form = $this->createForm(BankQuestionFormType::class, $bankQuestion, ['season' => $season]);
$form->handleRequest($request);
@@ -101,22 +101,21 @@ class QuestionBankController extends AbstractController
$this->addFlash(FlashType::Success, $this->translator->trans('Question added to the question bank'));
if ($isModalRequest) {
return new Response('', Response::HTTP_NO_CONTENT);
if ($isTurboFrame) {
return new Response('<turbo-frame id="bank-question-modal-frame"></turbo-frame>');
}
return $this->redirectToRoute('tvdt_backoffice_question_bank', ['seasonCode' => $season->seasonCode]);
}
$template = $isModalRequest
? 'backoffice/question_bank/_form_body.html.twig'
$template = $isTurboFrame
? 'backoffice/question_bank/_frame.html.twig'
: 'backoffice/question_bank/form.html.twig';
$response = $this->render($template, [
'season' => $season,
'form' => $form,
'bankQuestion' => null,
'isModal' => $isModalRequest,
]);
if ($form->isSubmitted()) {
@@ -137,7 +136,7 @@ class QuestionBankController extends AbstractController
{
$this->assertSameSeason($season, $bankQuestion->season);
$isModalRequest = $request->headers->has('X-Modal-Request');
$isTurboFrame = $request->headers->has('Turbo-Frame');
$form = $this->createForm(BankQuestionFormType::class, $bankQuestion, ['season' => $season]);
$form->handleRequest($request);
@@ -149,22 +148,21 @@ class QuestionBankController extends AbstractController
$this->addFlash(FlashType::Success, $this->translator->trans('Question updated'));
if ($isModalRequest) {
return new Response('', Response::HTTP_NO_CONTENT);
if ($isTurboFrame) {
return new Response('<turbo-frame id="bank-question-modal-frame"></turbo-frame>');
}
return $this->redirectToRoute('tvdt_backoffice_question_bank', ['seasonCode' => $season->seasonCode]);
}
$template = $isModalRequest
? 'backoffice/question_bank/_form_body.html.twig'
$template = $isTurboFrame
? 'backoffice/question_bank/_frame.html.twig'
: 'backoffice/question_bank/form.html.twig';
$response = $this->render($template, [
'season' => $season,
'form' => $form,
'bankQuestion' => $bankQuestion,
'isModal' => $isModalRequest,
]);
if ($form->isSubmitted()) {