Marijn/TijdVoorDeTest
1
0
Fork 0
mirror of https://github.com/MarijnDoeve/TijdVoorDeTest.git synced 2026-07-05 23:20:18 +02:00
Code Issues Packages Projects Releases Activity

fix: address CodeRabbit review findings

Browse Source 
- Use FlashType enum in clearQuiz/finalizeQuiz/unfinalizeQuiz (was raw 'success'/'error' strings)
- Catch UniqueConstraintViolationException in addLabel to handle concurrent duplicate inserts
- Wrap assignToQuiz in a transaction with PESSIMISTIC_WRITE lock to serialise concurrent assignments of the same BankQuestion
This commit is contained in:
Marijn Doeve
2026-07-04 22:07:13 +02:00
parent 8304d8680b
commit 5d51885c82
3 changed files with 39 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Controller/Backoffice/QuizController.php
+4 -4
View File
@@ -293,9 +293,9 @@ class QuizController extends AbstractController
$this->quizRepository->clearQuiz($quiz);
$quiz->finalizedAt = null;
$this->em->flush();
$this->addFlash('success', $this->translator->trans('Quiz cleared and no longer finalized'));
$this->addFlash(FlashType::Success, $this->translator->trans('Quiz cleared and no longer finalized'));
} catch (ErrorClearingQuizException) {
$this->addFlash('error', $this->translator->trans('Error clearing quiz'));
$this->addFlash(FlashType::Danger, $this->translator->trans('Error clearing quiz'));
}
return $this->redirectToRoute('tvdt_backoffice_quiz', ['seasonCode' => $quiz->season->seasonCode, 'quiz' => $quiz->id]);
@@ -316,7 +316,7 @@ class QuizController extends AbstractController
} elseif (!$quiz->isFinalized()) {
$quiz->finalizedAt = new DateTimeImmutable();
$this->em->flush();
$this->addFlash('success', $this->translator->trans('Quiz finalized'));
$this->addFlash(FlashType::Success, $this->translator->trans('Quiz finalized'));
}
return $this->redirectToRoute('tvdt_backoffice_quiz', ['seasonCode' => $quiz->season->seasonCode, 'quiz' => $quiz->id]);
@@ -339,7 +339,7 @@ class QuizController extends AbstractController
} else {
$quiz->finalizedAt = null;
$this->em->flush();
$this->addFlash('success', $this->translator->trans('Quiz is no longer finalized'));
$this->addFlash(FlashType::Success, $this->translator->trans('Quiz is no longer finalized'));
}
return $this->redirectToRoute('tvdt_backoffice_quiz', ['seasonCode' => $quiz->season->seasonCode, 'quiz' => $quiz->id]);